libftdi Archives

Subject: Re: Re: [PATCH] Replace eeprom->rs232_inversion with eeprom->invert.

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Tue, 28 Oct 2014 09:38:03 +0100
Hi Florian,

On Thursday, 23. October 2014 08:42:31 Florian Preinstorfer wrote:
> > you are right, eeprom->rs232_inversion is the same as eeprom->invert.
> > To replacing it is good. However i propose to split up yout patch in two
> > parts:
> > - first replacing rs232_inversio vs. invert.
> > - second introducing the printout function.
> > 
> > This will help regression testing.
> 
> Hi Uwe.
> 
> Good point, thanks for reviewing the patch. Please find two patches
> attached, that split up the rs232_inversion replacement and the printout
> function.

both patches have been applied. I've double checked the removal
of the "RS232_INVERSION" eeprom API definition and it was safe to remove it:
It was never part of an official release and also just added on 2014-09-14.

I guess the only one that needs to change his code is Uwe :D

Cheers,
Thomas

Attachment: signature.asc
Description: This is a digitally signed message part.

Current Thread