libftdi Archives

Subject: Re: [PATCH] Replace eeprom->rs232_inversion with eeprom->invert.

From: Florian Preinstorfer <fp@xxxxxxx>
To: <libftdi@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 23 Oct 2014 08:42:31 +0200
> you are right, eeprom->rs232_inversion is the same as eeprom->invert.
> To replacing it is good. However i propose to split up yout patch in two
> parts:
> - first replacing rs232_inversio vs. invert.
> - second introducing the printout function.
> 
> This will help regression testing.
Hi Uwe.

Good point, thanks for reviewing the patch. Please find two patches
attached, that split up the rs232_inversion replacement and the printout
function.

best regards,
Florian

Attachment: 0001-Replace-eeprom-rs232_inversion-with-eeprom-invert.patch
Description: Text Data

Attachment: 0002-Add-print_inverted_bits-to-replace-a-duplicated-code.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature

Current Thread