libftdi Archives

Subject: Re: Re: [PATCH] Replace eeprom->rs232_inversion with eeprom->invert.

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Thu, 23 Oct 2014 16:00:05 +0200
Hi Florian,

On Thursday, 23. October 2014 08:42:31 Florian Preinstorfer wrote:
> > you are right, eeprom->rs232_inversion is the same as eeprom->invert.
> > To replacing it is good. However i propose to split up yout patch in two
> > parts:
> > - first replacing rs232_inversio vs. invert.
> > - second introducing the printout function.
> > 
> > This will help regression testing.
> 
> Hi Uwe.
> 
> Good point, thanks for reviewing the patch. Please find two patches
> attached, that split up the rs232_inversion replacement and the printout
> function.

thanks for splitting the patch and also Uwe for the review.
I'll take a look at them soonish.

[My planning got messed up again: First two shell shock updates and now an 
SSLv3 poodle ;) You can't really plan for security issues / upgrades.]

Cheers,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread