libftdi Archives

Subject: Re: [PATCH] Replace eeprom->rs232_inversion with eeprom->invert.

From: Uwe Bonnes <bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Wed, 22 Oct 2014 19:26:41 +0200
>>>>> "Florian" == Florian Preinstorfer <fp@xxxxxxx> writes:

    Florian> Hi, any comments on the patch or objections against merging?

Hi Florian,

you are right, eeprom->rs232_inversion is the same as eeprom->invert.
To replacing it is good. However i propose to split up yout patch in two
parts:
- first replacing rs232_inversio vs. invert.
- second introducing the printout function.

This will help regression testing.

Bye
-- 
Uwe Bonnes                bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread