libftdi Archives

Subject: Re: Re: [PATCH] ftdi_eeprom: reliable device selection and flashing of new VID/PIDs

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: Robin Haberkorn <haberkorn@xxxxxxxxxxxx>
Date: Wed, 04 Mar 2015 16:23:17 +0100
On Wednesday, 25. February 2015 20:56:58 Robin Haberkorn wrote:
> Nevertheless, my patch does not really affect ftdi_eeprom's behaviour in
> this regard as ftdi_eeprom used the following check on command-line
> arguments in 1162549f which effectively limits you to performing a
> single command per ftdi_eeprom invocation:
> 
>     if (argc != 2 && argc != 3)
>     {
>         printf("Syntax: %s [commands] config-file\n", argv[0]);
>         printf("Valid commands:\n");
>         printf("--read-eeprom  Read eeprom and write to -filename- from
> config-file\n");
>         printf("--erase-eeprom  Erase eeprom\n");
>         printf("--flash-eeprom  Flash eeprom\n");
>         exit (-1);
>     }
> 
> What the patch changes is allowing an arbitrary number of parameters so
> that the optional "--device" option can be supported.

Good point. I've applied your patch with a minor typo fix.

Thanks,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread