Hi Robin,
On 01/27/2015 11:21 PM, Robin Haberkorn wrote:
> ftdi_eeprom currently does not allow you to specify the FTDI device
> reliably/uniquely, nor is reflashing of the VID/PID allowed in every case.
>
> I attached a patch (02-ftdi_eeprom_device_selection.patch) fixing this.
> It applies on top of the last patch I sent, which I'm attaching here
> again for convenience (01-cbusx.patch).
I've reviewed and applied the 01-cbusx.patch.
Thanks for this high quality contribution.
How did you generate the patch file? Using "Write commit to file" in gitk?
Please use "git format-patch HEAD~XXX" the next time. Then I can just
apply them via "git am" without manually copying the commit msg etc. over.
Regarding the ftdi_eeprom patch: It alters the current behavior.
If someone uses "--erase" together with "--flash", it is no longer possible.
Imagine someone wants to flash a shorter eeprom than
the one that's currently on the chip, then "--erase"
is really helpful to ensure there's no garbage left.
What do you think?
Cheers,
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|
