>>>>> "Thomas" == Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx> writes:
Thomas> I've reviewed and applied your patches. Thanks!
Thanks for the review.
Thomas> The ftdi_write_data() constness patch was already included in
Thomas> September 2013, so I've skipped that.
Thomas> Though I'm not sure about the ftdi_eeprom_build() change: Do we
Thomas> really need to call ftdi_read_eeprom_location() in there? It's
Thomas> something the user might not expect from a xxx_build() function.
You mean reading the bytes between 0x40 and 0x50? These bytes need to be
known for the checksum calculation.
--
Uwe Bonnes bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|