libftdi Archives

Subject: Re: FT2320X patches, next round

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Fri, 16 May 2014 17:03:23 +0200
Hi Uwe,

On Friday, 25. April 2014 10:50:37 Uwe Bonnes wrote:
> the errors I saw were mostly related to the user program not reading the
> eeprom in some situations and so flagging a wrong checksum. I also sharped
> some rules for eeprom decoding, so some nonsense output for the FT2320x
> is removed.

I've reviewed and applied your patches. Thanks!

The ftdi_write_data() constness patch was already included in September 
2013, so I've skipped that.


Though I'm not sure about the ftdi_eeprom_build() change:
Do we really need to call ftdi_read_eeprom_location() in there?
It's something the user might not expect from a xxx_build() function.

Cheers,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread