Hi Michel,
On Thursday, 24. January 2013 15:07:15 xantares 09 wrote:
> > Nice! What about the variable names themselves?
> > They are still called "LIBFTDI_XXXX":
> >
> > Shouldn't they also be called LIBFTDI1_XXXX for consistency?
>
> Hi,
>
> - Yes, it's more consistent with the config file name, and practical for
> packaging.
I'm not sure I fully understand you here. But anyway,
I gave it another thought:
Projects making use of the new cmake feature do
find_package ( LibFTDI1 NO_MODULE REQUIRED )
include ( ${LIBFTDI_USE_FILE} )
...
target_link_libraries( example ${LIBFTDI_LIBRARIES} )
If they later on decide to upgrade to libftdi 2.x, they just have to use
"find_package ( LibFTDI2 NO_MODULE REQUIRED )", all the other statements stay
the same.
I think it's highly unlikely one needs libftdi 1.x and libftdi 2.x
in the same project.
So I'll keep your code like it is and will prepare
the final release candidate (rc3).
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|
