libftdi Archives

Subject: Re: [1/5]new-baudrate-code/origin: The BM_type_chip option no longer exists

From: Uwe Bonnes <bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Thu, 8 Sep 2011 20:25:44 +0200
>>>>> "Thomas" == Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx> writes:

    Thomas> Hi Uwe, On Thursday, 8. September 2011 10:11:00 Uwe Bonnes
    Thomas> wrote:
    >> The following set of patches is done against
    >> new-baudrate-code. Either apply them to new-baudrate-code and then
    >> move the whole tree to roigin when you feel comfordable with it, or
    >> apply to 1.0 too

    Thomas> I've put them in "master" as I want to keep the baudrate changes
    Thomas> separate.

    Thomas> Regarding the baudrate branch, should we just "fix" up the
    Thomas> result for the AM type chips and merge it or do you want to
    Thomas> tweak it some more if someone comes up with a real working AM
    Thomas> type chip?

The AM is really an artefact. I hopefully didn't touch the code, so the
results should remain as they where before. The compare references is what i
_think_ is right, but I have no mean to test. The chip itself is EOL.

So my incentive to further work on it is not high at the moment. And it
shouldn't hinder us to move on. So best let's remove the offending cases. 
Any objections?

-- 
Uwe Bonnes                bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
diff --git a/test/baudrate.cpp b/test/baudrate.cpp
index d0e2cc4..0c5bc6b 100644
--- a/test/baudrate.cpp
+++ b/test/baudrate.cpp
@@ -124,7 +124,6 @@ BOOST_AUTO_TEST_CASE(TypeAMFixedBaudrates)
     ftdi->type = TYPE_AM;
 
     map<int, calc_result> baudrates;
-    baudrates[183] = calc_result(183, 16383, 3, 48);
     baudrates[300] = calc_result(300, 10000, 0, 48);
     baudrates[600] = calc_result(600,  5000, 0, 48);
     baudrates[1200] = calc_result(1200, 2500, 0, 48);
@@ -141,12 +140,10 @@ BOOST_AUTO_TEST_CASE(TypeAMFixedBaudrates)
     baudrates[1000000] = calc_result(1000000, 3, 0, 48);
     baudrates[1090512] = calc_result(1000000, 3, 0, 48);
     baudrates[1090909] = calc_result(1000000, 3, 0, 48);
-    baudrates[1090910] = calc_result(1200000, 2, 1, 48);
     baudrates[1200000] = calc_result(1200000, 2, 1, 48);
     baudrates[1333333] = calc_result(1333333, 2, 2, 48);
     baudrates[1411764] = calc_result(1411765, 2, 3, 48);
     baudrates[1500000] = calc_result(1500000, 2, 0, 48);
-    baudrates[2000000] = calc_result(2000000, 1, 0, 48);
     baudrates[3000000] = calc_result(3000000, 0, 0, 48);
 
     test_baudrates(ftdi, baudrates);

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread