Hello Nathan,
On Monday, 27. July 2009 13:21:06 Nathan Fraser wrote:
> 2009/7/27 Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>:
> > Maybe we should prefix the function name with "ftdi_" to indicate
> > this belongs to libftdi. Something like ftdi_usb_close() ;-)
>
> Except this is not a function that anything outside of ftdi.c should
> ever see. Naming is entirely up to you, as long as the basic operation
> stays I'll be very happy.
Ok, I'll try to find some nice name and will also make the function
"static", thereby it's not visible outside ftdi.c.
> > What about adding the "if (ftdi->usb_dev != NULL)"
> > check to the already existing ftdi_usb_close()?
>
> I forgot about that, and there is a problem still there. Just call
> ftdi_usb_close(...) twice on the same handle to see it in action. Both
> functions are still needed since there are places where a usb close is
> called, but where control can get back to a calling application.
> Imagine:
>
> - app calls ftdi lib function,
> * function fails in ftdi lib, usb_close called, error flags returned
> - app decised to recover from error and calls ftdi_usb_close
> * segfault.
You convinced me. I'll integrate your patch soonish.
Thanks!
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|
