Correct (signedness) issues detected by -Wall

diff --git a/examples/baud_test.c b/examples/baud_test.c
index 32b9beb..b53031b 100644 (file)
--- a/examples/baud_test.c
+++ b/examples/baud_test.c
@@ -52,8 +52,8 @@ int main(int argc, char **argv)
 {
     struct ftdi_context ftdic;
     int i, t;
-    char *txbuf;
-    char *rxbuf;
+    unsigned char *txbuf;
+    unsigned char *rxbuf;
     double start, duration, plan;
 
     // default values

diff --git a/examples/serial_read.c b/examples/serial_read.c
index c8f2ea4..5d05d66 100644 (file)
--- a/examples/serial_read.c
+++ b/examples/serial_read.c
@@ -14,7 +14,7 @@
 int main(int argc, char **argv)
 {
     struct ftdi_context ftdic;
-    char buf[1024];
+    unsigned char buf[1024];
     int f, i;
     int vid = 0x0403;
     int pid = 0x6001;
@@ -79,4 +79,6 @@ int main(int argc, char **argv)
 
     ftdi_usb_close(&ftdic);
     ftdi_deinit(&ftdic);
+
+    return 0;
 }

diff --git a/src/ftdi.c b/src/ftdi.c
index 525f9d1..30b5b55 100644 (file)
--- a/src/ftdi.c
+++ b/src/ftdi.c
@@ -2659,7 +2659,7 @@ int ftdi_read_eeprom_location (struct ftdi_context *ftdi, int eeprom_addr, unsig
     if (ftdi == NULL || ftdi->usb_dev == NULL)
         ftdi_error_return(-2, "USB device unavailable");
 
-    if (libusb_control_transfer(ftdi->usb_dev, FTDI_DEVICE_IN_REQTYPE, SIO_READ_EEPROM_REQUEST, 0, eeprom_addr, (char *)eeprom_val, 2, ftdi->usb_read_timeout) != 2)
+    if (libusb_control_transfer(ftdi->usb_dev, FTDI_DEVICE_IN_REQTYPE, SIO_READ_EEPROM_REQUEST, 0, eeprom_addr, (unsigned char *)eeprom_val, 2, ftdi->usb_read_timeout) != 2)
         ftdi_error_return(-1, "reading eeprom failed");
 
     return 0;

diff --git a/src/ftdi_stream.c b/src/ftdi_stream.c
index c3eb465..d39fc2a 100644 (file)
--- a/src/ftdi_stream.c
+++ b/src/ftdi_stream.c
@@ -198,7 +198,7 @@ ftdi_readstream(struct ftdi_context *ftdi,
      */
     if (ftdi_set_bitmode(ftdi,  0xff, BITMODE_SYNCFF) < 0)
     {
-        fprintf(stderr,"Can't set synchronous fifo mode\n",
+        fprintf(stderr,"Can't set synchronous fifo mode: %s\n",
                 ftdi_get_error_string(ftdi));
         goto cleanup;
     }