libftdi Archives

Subject: Re: Minor warning for example bitbang_cbus.c

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Mon, 24 Aug 2020 19:46:20 +0200
Hi Xiaofan,

You wrote on Fri, Jul 31, 2020 at 11:09:15AM +0800:
> There is a minor warning when building libftdi (latest git) under Ubuntu 
> 20.04.
> 
> [ 63%] Building C object examples/CMakeFiles/bitbang_cbus.dir/bitbang_cbus.c.o
> /home/mcuee/Desktop/build/libftdi/libftdi/examples/bitbang_cbus.c: In
> function ‘main’:
> /home/mcuee/Desktop/build/libftdi/libftdi/examples/bitbang_cbus.c:63:9:
> warning: ignoring return value of ‘fgets’, declared with attribute
> warn_unused_result [-Wunused-result]
>    63 |         fgets(input, sizeof(input) - 1, stdin);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 

I did a quick fix, compile tested only.

> As for the Python wrapper related warnings, they have been there long
> ago so I think
> probably it is related to swig or things like that. No idea about them.

yeah, the SWIG wrapper wraps all the functions 1:1 if possible, including 
the "bad behaving" ones. We could probably map them to the new functions, 
but no idea about side effects without proper testing.

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread