libftdi Archives

Subject: Re: [PATCH] python/CMakeLists.txt: fix build with cmake < 3.7

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
Date: Mon, 21 Jan 2019 16:17:33 +0100
Hi Fabrice,

You wrote on Sat, Jan 19, 2019 at 09:42:01PM +0100:
> VERSION_GREATER_EQUAL has been added only in cmake 3.7:
> https://cmake.org/cmake/help/v3.7/release/3.7.html
> 
> So replace this statement by NOT CMAKE_VERSION VERSION_LESS
> 
> Fixes:
>  - 
> http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
> ---
>  python/CMakeLists.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
> index 7bdd9f9..376dae6 100644
> --- a/python/CMakeLists.txt
> +++ b/python/CMakeLists.txt
> @@ -1,5 +1,5 @@
>  # workaround for cmake bug #0013449
> -if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR CMAKE_VERSION VERSION_GREATER_EQUAL 
> 3.0.0 )
> +if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR NOT CMAKE_VERSION VERSION_LESS 
> 3.0.0 )
>    find_package ( SWIG REQUIRED )
>  else ()
>    find_program ( SWIG_EXECUTABLE NAMES swig2.0 swig )

applied, thanks! I've tested the swig wrapper
still builds with cmake version 3.11.2.

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread