libftdi Archives

Subject: Re: [PATCH] CMake: move options to a dedicated file

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: yegorslists@xxxxxxxxxxxxxx
Date: Mon, 5 Feb 2018 23:36:48 +0100
Hi Yegor,

On 01/03/2018 01:46 PM, Yegor Yefremov wrote:
> Also disable all options having extra dependencies.
> 
> If an option is selected makes its dependencies as REQUIRED.

thanks for the big patch. It's almost merged :)

What needs a bit of discussion is the change in default behavior:

The old cmake script was "best effort": If you f.e. had libconfuse
installed, ftdi_eeprom was automatically build.

With the new way of doing things, ftdi_eeprom needs to be enabled upon
request. This changes user expectations that have grown over many years.

Do you think we can re-enable ftdi_eeprom
and the python bindings by default?
Not sure how widespread the C++ wrapper is used.

What about having libconfuse / boost library detection
in CMakeOptions.txt to set the default values?

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread