Hello Eric,
thanks for your patch! Some questions below.
On Monday, 10 April 2017 15:54:15 CEST Eric Schott wrote:
> The provided patch is at the user's risk.
> No licensing of this patch can preclude its use by the governement of
> the United States or The Applied Research Laboratory of The
> Pennsylvania State University.
would you be ok with licensing the purge_test.c code
as GPL v2 like the other example codes?
That would still fulfill your "license requirement" above.
Perhaps it's a good idea to split the purge fix,
the new example code and the C++ fixes into three (logical) commits.
> diff --git a/src/ftdi.h b/src/ftdi.h
> index bb66c53..acc1869 100644
> --- a/src/ftdi.h
> +++ b/src/ftdi.h
> @@ -173,8 +173,8 @@ enum ftdi_module_detach_mode
>
>
> #define SIO_RESET_SIO 0
> -#define SIO_RESET_PURGE_RX 1
> -#define SIO_RESET_PURGE_TX 2
> +#define SIO_RESET_PURGE_TX 1
> +#define SIO_RESET_PURGE_RX 2
this change puzzles me. I've searched for my original USB "API documentation"
received under NDA in 2003 and it specifies these control values:
0: Reset SIO
1: Purge RX buffer
2: Purge TX buffer.
Did you run your tests only with the FT4232 type chips?
Also you mention the purge doesn't work correctly,
even after fixing it?
I guess there's an equivalent purge function in D2XX,
it might make sense to take a look either at the sent USB URBs
or I might even disassemble the purge function of it.
(which is legal in Germany as long as it's to ensure compatibility)
Cheers,
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|
