libftdi Archives

Subject: Re: Re: Suggested patch for adding ftdi_transfer_data_cancel

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: Eugene Hutorny <eugene@xxxxxxxxxxxxx>
Cc: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Wed, 13 Apr 2016 14:37:45 +0200
Hi Eugene,

On Monday, 28. March 2016 17:22:39 Eugene Hutorny wrote:
> In the existing code tc->completed is used as boolean.
> Definitely it is not an error. Perhaps it would make sense to use
> TRUE/FALSE,
> but I am not sure if it worth refactoring.

my point was that libftdi doesn't own the "tc" data structure. It's part
of libusb and we shouldn't write numerical values directly into it.

Luckily for us the values map to the desired behavior (f.e. 
LIBUSB_TRANSFER_ERROR => 1) in libusb and are unlikely to change.

Cheers,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread