libftdi Archives

Subject: Re: [PATCH] Enable searching for FTDI devices with either a VID or PID of zero

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: Forest Crossman <cyrozap@xxxxxxxxx>
Date: Wed, 05 Nov 2014 15:38:04 +0100
Hi Forest,

thanks for the patch. Comments below:

On Friday, 31. October 2014 13:17:16 Forest Crossman wrote:
> @@ -328,9 +328,9 @@ int ftdi_usb_find_all(struct ftdi_context *ftdi,
> struct ftdi_device_list **devli if (libusb_get_device_descriptor(dev,
> &desc) < 0)
>              ftdi_error_return_free_device_list(-6,
> "libusb_get_device_descriptor() failed", devs);
> 
> -        if (((vendor != 0 && product != 0) &&
> +        if (((vendor || product) &&
>                  desc.idVendor == vendor && desc.idProduct == product) ||

that part is fine by me. That should allow us
to find devices with the famous zero PID.

> -                ((vendor == 0 && product == 0) &&
> +                (!(vendor || product) &&
>                   (desc.idVendor == 0x403) && (desc.idProduct == 0x6001 ||

I currently don't see the reason why this part of the code was changed?
Can't we keep the current logic (which is easier to read)? Am I missing 
something?

Cheers,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread