Re: [libftdi-1.0] [PATCH] bug fix for async write and read

[Yi-Shin Li <ysli@xxxxxxxxxxxxx>]

Hi Thomas,

On Tue, Jul 13, 2010 at 11:34 PM, Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx> wrote

On Sunday, 11. July 2010 17:34:11 Yi-Shin Li wrote:

> --- /dev/null

> +++ b/autogen.sh
> @@ -0,0 +1,48 @@
> +#! /bin/sh

> ...
> ...

We are currently discussing the removal of autoconf from libftdi 1.x,
so I'm going to delay that part of the patch if you don't mind.

That's okay. Just so you know that I use autoconf together with pbuilder to generate Debian binary packages.
 

> --- a/src/ftdi.c
> +++ b/src/ftdi.c

> @@ -1514,17 +1516,20 @@ int ftdi_transfer_data_done(struct
> ftdi_transfer_control *tc)
>                      break;
>              libusb_free_transfer(tc->transfer);
>              free (tc);
> -            tc = NULL;
>              return ret;
>          }
>      }

Do I see it correctly that this change was made
to remove "useless" code, right?

Yes, because the caller doesn't know it (tc=NULL). It's a call by value pointer not a reference.

Regards,
Yi-Shin

---

libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx