Hi Martin,
On Friday, 9. July 2010 15:45:09 Martin Zenzes wrote:
> > - Rename ftdi_library_version() to ftdi_get_library_version()
>
> done...
Thanks.
> > - Maybe add a "char *snapshot_version" which can return NULL / empty
> > string?
> >
> > See guess-rev.sh
>
> done/TODO. Added "char snapshot_version[8]" (fix-sized array to prevent
> possible memory-leaks, is just set completely to zero in the
> moment...?). How to say cmake to invoke a shell-script at buildtime to
> dynamically define #defines in the header file?
The fixed size array will not be enough if git is unable to come up with
a short version of the md5 (f.e. if two md5 sums are close to each other).
I guess we can figure the shell script invocation out,
though we shouldn't abort the build process if it fails (f.e. on Win32).
> > - Provide autoconf support
>
> TODO/drop?
If the patch is for libftdi-1.x only, then yes.
> > Regarding the third point, we could just apply this patch
> > to libftdi 1.x and drop the autoconf support completly. So libftdi 0.x
> > would be put in maintenance mode and only receive bug fixes.
>
> I'm not in the position to decide something in this issue, but it seems
> to me that supporting different build-methods is confusing and
> error-prone to new users... At least it was to me ;)
Not only to new users ;) I'll send a separate mail about it,
libftdi-1.x is the right time to deprecate autohell.
Cheers,
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|
