Define new capture output flag for python 3.7 which is false by default
authorPlamen Dimitrov <pdimitrov@pevogam.com>
Tue, 26 Mar 2019 07:30:50 +0000 (15:30 +0800)
committerChristian Herdtweck <christian.herdtweck@intra2net.com>
Tue, 9 Apr 2019 07:40:06 +0000 (09:40 +0200)
This is a bad indicator of the backwards compatibility of minor versions
since adding the flag with a default like this would probably break a
lot of code down there. Sometimes it seems that python developers are
not really concerned with how many things they break in their minors.

src/arnied_wrapper.py

index 9a39d62..c2ba2cc 100644 (file)
@@ -103,7 +103,7 @@ def run_cmd(cmd="", ignore_errors=False, vm=None, timeout=60):
         if sys.version_info.major <= 3 and sys.version_info.minor < 5:
             return call_helpers.subprocess_run(cmd, check=not ignore_errors, shell=True)
         else:
-            return subprocess.run(cmd, check=not ignore_errors, shell=True)
+            return subprocess.run(cmd, check=not ignore_errors, shell=True, capture_output=True)
 
 
 def verify_running(process='arnied', timeout=60, vm=None):