in case of unknown ICMP reply type, consume data instead of returning failure in...

diff --git a/src/icmp/icmpdata.h b/src/icmp/icmpdata.h
index 7e92f64..f53f160 100644 (file)
--- a/src/icmp/icmpdata.h
+++ b/src/icmp/icmpdata.h
@@ -42,6 +42,8 @@ class IcmpData
 public:
     IcmpData();
 
+    IcmpData(const std::size_t size_arg);
+
     virtual ~IcmpData() {};
 
     virtual bool match_echo_reply(const uint16_t identifier,
@@ -75,9 +77,6 @@ public:
 
 protected:
 
-    // called by subclasses
-    IcmpData(const std::size_t size_arg);
-
     std::size_t size;
     MessagePayload raw_data;
 };

diff --git a/src/icmp/icmppacket.cpp b/src/icmp/icmppacket.cpp
index 95bb8a4..b90f481 100644 (file)
--- a/src/icmp/icmppacket.cpp
+++ b/src/icmp/icmppacket.cpp
@@ -213,7 +213,12 @@ IcmpPacket::ReadReturnCode IcmpPacket::read( std::istream &is )
             icmp_data_ptr.reset( new IcmpDestinationUnreachableData(
                                        static_cast<std::size_t>(data_length)) );
         else
-            return ReadReturnCode_UNKNOWN_ICMP_TYPE;
+        {   // unspecified icmp data type, will consume right amount of data
+            //   from stream but return false for match_echo_request and
+            //   match_destination_unreachable 
+            icmp_data_ptr.reset( new IcmpData(
+                                       static_cast<std::size_t>(data_length)) );
+        }
         icmp_data_ptr->read( is );
     }