libi2ncommon
15 years agoMerge branch 'glibc-upgrade' into amavisd-update
Gerd von Egidy [Wed, 27 Jan 2010 16:21:27 +0000]
Merge branch 'glibc-upgrade' into amavisd-update

Conflicts:
packages/autoconf/autoconf.spec
packages/python/python.spec
packages/sqlite/sqlite.spec

15 years agomove exception.hxx from arnieclient into i2ncommon
Gerd von Egidy [Fri, 15 Jan 2010 16:05:44 +0000]
move exception.hxx from arnieclient into i2ncommon

it is used within i2ncommon so we have circular dependencies. this move fixes it.

15 years agomove exception.hxx from arnieclient into i2ncommon
Gerd von Egidy [Fri, 15 Jan 2010 16:05:44 +0000]
move exception.hxx from arnieclient into i2ncommon

it is used within i2ncommon so we have circular dependencies. this move fixes it.

15 years agoMerge remote branch 'origin/glibc-upgrade' into amavisd-update
Gerd von Egidy [Thu, 14 Jan 2010 11:10:19 +0000]
Merge remote branch 'origin/glibc-upgrade' into amavisd-update

Conflicts:
packages/amavisd-new/amavisd-new.spec

15 years agoMerge remote branch 'origin/glibc-upgrade' into amavisd-update
Gerd von Egidy [Fri, 8 Jan 2010 16:10:30 +0000]
Merge remote branch 'origin/glibc-upgrade' into amavisd-update
want to profit from the new developments and make cherry-picking more easy

Conflicts:
packages/amavisd-new/amavisd-new.spec

15 years agoMerge branch 'master' into glibc-uprade-HEAD-merge
Thomas Jarosch [Wed, 23 Dec 2009 14:59:39 +0000]
Merge branch 'master' into glibc-uprade-HEAD-merge

Conflicts:
add_dhcp_client/add_dhcp_client.spec
arniesetup/arniesetup.spec
backup_push/backup_push.spec
check_ip_conflict/check_ip_conflict.spec
configuration/etc/crontab
get_cnf/get_cnf.spec
info_fetchmail/info_fetchmail.spec
info_iponline/info_iponline.spec
initramfs/initramfs.spec
keymgt/keymgt.spec
libcnffile/config.h.in
libcnffile/libcnffile.spec
misc/git_webexport.sh
packages/Mail-SpamAssassin/Mail-SpamAssassin.spec
packages/amavisd-new/amavisd-new.spec
packages/bind/bind.spec
packages/cmake/cmake.spec
packages/curl-ssl/curl-ssl.spec
packages/cyrus-imapd/cyrus-imapd.spec
packages/fetchmail/fetchmail.spec
packages/file/file-disable-msdos-com.patch
packages/file/file.spec
packages/fsav/fsav.spec
packages/fsavpkgupdate/fsavpkgupdate.spec
packages/git/git-mkdtemp-old-glibc.patch
packages/git/git.spec
packages/initscripts/initscripts.spec
packages/iproute/iproute.spec
packages/iptables/iptables.spec
packages/libpng/libpng.spec
packages/libt2n/libt2n.spec
packages/libtiff/libtiff.spec
packages/logcheck/logcheck.spec
packages/newt/newt.spec
packages/openssl/openssl.spec
packages/perl-IO-Socket-SSL/perl-IO-Socket-SSL.spec
packages/perl/perl.spec
packages/php/php.spec
packages/postfix/postfix.spec
packages/samba/samba.spec
packages/squid/squid.spec
packages/squidguard/squidguard.spec
packages/strongswan/strongswan.spec
packages/udev/udev.spec
packages/webmail/webmail.spec
ui/ui/form_antivirus_quarantine.cpp
wol/wol.spec

15 years agoMerge branch 'vpn-psk-anyid'
Thomas Jarosch [Tue, 22 Dec 2009 14:09:09 +0000]
Merge branch 'vpn-psk-anyid'

15 years agoMerge remote branch 'origin/update-522'
Thomas Jarosch [Tue, 15 Dec 2009 20:14:35 +0000]
Merge remote branch 'origin/update-522'

15 years agoMerge branch 'iphone-vpn' into update-522
Thomas Jarosch [Mon, 14 Dec 2009 10:31:39 +0000]
Merge branch 'iphone-vpn' into update-522

15 years agoMerge branch 'iphone-vpn' into update-522
Thomas Jarosch [Sat, 12 Dec 2009 18:46:24 +0000]
Merge branch 'iphone-vpn' into update-522

15 years agoMerge remote branch 'origin/iphone-vpn' into update-522
Thomas Jarosch [Sat, 12 Dec 2009 18:02:53 +0000]
Merge remote branch 'origin/iphone-vpn' into update-522

15 years agoIncrease release version for smooth upgrade process. Otherwise dependency calculation...
Thomas Jarosch [Tue, 1 Dec 2009 15:08:46 +0000]
Increase release version for smooth upgrade process. Otherwise dependency calculation will fail

15 years agoAdded libgettex requirement to libi2ncommon
Thomas Jarosch [Thu, 26 Nov 2009 11:41:32 +0000]
Added libgettex requirement to libi2ncommon

15 years agoMerge branch 'spamfilter-first-trusted' into master
Thomas Jarosch [Thu, 27 Aug 2009 08:13:15 +0000]
Merge branch 'spamfilter-first-trusted' into master

Conflicts:
intranator-language/usr/intranator/lang/de/LC_MESSAGES/ui-data.mo
intranator-language/usr/intranator/lang/de/LC_MESSAGES/ui-data.po
orga/releasetests/tests-5.1.6.txt
orga/releasetests/tests-5.1.7.txt
packages/Mail-SpamAssassin/Mail-SpamAssassin.spec
packages/logcheck/logcheck-patterns/ignore.d.server/intranator
sarules/50_i2n_scores.cf
sarules/i2n-rules.cf
sarules/ixhash.cf
sarules/sarules.spec
update_cnf/src/update_5.1.7.cpp

15 years agoFix pipestream includes
Thomas Jarosch [Thu, 6 Aug 2009 12:40:00 +0000]
Fix pipestream includes

15 years agoFix libi2ncommon for gcc4
Thomas Jarosch [Mon, 3 Aug 2009 14:52:26 +0000]
Fix libi2ncommon for gcc4

16 years agoRe-enable new cron class test results using new glibc
Thomas Jarosch [Mon, 25 May 2009 08:46:08 +0000]
Re-enable new cron class test results using new glibc

16 years agoAdjust to libiconv API change
Thomas Jarosch [Mon, 25 May 2009 08:45:47 +0000]
Adjust to libiconv API change

16 years agoProperly depend on ../utils
Thomas Jarosch [Mon, 25 May 2009 08:45:18 +0000]
Properly depend on ../utils

16 years agoMerge branch 'squid-v3' into intranator-next
Gerd von Egidy [Tue, 12 May 2009 15:42:12 +0000]
Merge branch 'squid-v3' into intranator-next

16 years agoMerge branch 'master' into squid-v3
Gerd von Egidy [Mon, 11 May 2009 15:39:51 +0000]
Merge branch 'master' into squid-v3

Conflicts:
libcnfcheck/src/check_var/cnfcheck_proxy.cpp
libcnfcheck/src/check_var/cnfcheck_system.cpp
libfirewall/src/fw_ruleset_obj.cpp
libfirewall/src/fw_ruleset_obj.hxx
packages/squid/squid.spec

16 years agoFix arnied scheduler by redefining StNimmerleinsDay from -1 to INT_MAX -> arnied...
Thomas Jarosch [Mon, 27 Apr 2009 12:21:17 +0000]
Fix arnied scheduler by redefining StNimmerleinsDay from -1 to INT_MAX -> arnied's scheduler uses signed int to calculate dates

16 years agoIncrease version
Thomas Jarosch [Mon, 20 Apr 2009 12:43:10 +0000]
Increase version

16 years agoMerge commit 'origin/fsav-upgrade'
Thomas Jarosch [Fri, 17 Apr 2009 11:22:30 +0000]
Merge commit 'origin/fsav-upgrade'

16 years agomake sure that no invalid time values are written to firewall (#1423)
Gerd von Egidy [Thu, 16 Apr 2009 13:53:30 +0000]
make sure that no invalid time values are written to firewall (#1423)
new common function split_daysec() to replace the dated seconds_to_hour_minute()

16 years agoincrease libi2ncommon version as it is incompatible after dividing it by licenses...
Gerd von Egidy [Thu, 9 Apr 2009 16:55:49 +0000]
increase libi2ncommon version as it is incompatible after dividing it by licenses, fix libtool build

16 years agoChange some cron time unit test until we have a fixed glibc
Thomas Jarosch [Mon, 6 Apr 2009 14:34:52 +0000]
Change some cron time unit test until we have a fixed glibc

16 years agoMerge branch 'schedulefix-with-new-glibc'
Thomas Jarosch [Mon, 6 Apr 2009 14:27:31 +0000]
Merge branch 'schedulefix-with-new-glibc'

16 years agoRelicensed signalfunc and containerfunc as GPL version 2 + linking exception. Moved...
Thomas Jarosch [Mon, 6 Apr 2009 13:59:50 +0000]
Relicensed signalfunc and containerfunc as GPL version 2 + linking exception. Moved this submodule to a separate utils directory/RPM package.

16 years agofix unit-tests - the results were ok for the new code, remove debugging-output
Gerd von Egidy [Fri, 3 Apr 2009 15:58:15 +0000]
fix unit-tests - the results were ok for the new code, remove debugging-output

16 years agoimprove WeekCron-unittests some more
Gerd von Egidy [Thu, 2 Apr 2009 15:59:33 +0000]
improve WeekCron-unittests some more

16 years agofirst shot at fixing WeekCron-login, not done yet (#1551)
Gerd von Egidy [Tue, 31 Mar 2009 16:19:02 +0000]
first shot at fixing WeekCron-login, not done yet (#1551)

16 years agoMerge branch 'strongswan-v4'
Gerd von Egidy [Tue, 31 Mar 2009 08:57:15 +0000]
Merge branch 'strongswan-v4'

Conflicts:
.gitignore
packages/strongswan/strongswan.spec

16 years agoMerge branch 'intranator-next'
Thomas Jarosch [Tue, 31 Mar 2009 08:20:57 +0000]
Merge branch 'intranator-next'

16 years agoAdded unit test for wrong scheduling of intervals (Ã#1551)
Thomas Jarosch [Mon, 30 Mar 2009 09:50:30 +0000]
Added unit test for wrong scheduling of intervals (Ã#1551)

16 years agoIncrease version
Thomas Jarosch [Tue, 10 Mar 2009 10:09:42 +0000]
Increase version

16 years agoMerge branch 'arnied-scheduler'
Thomas Jarosch [Sat, 14 Feb 2009 21:38:26 +0000]
Merge branch 'arnied-scheduler'

Conflicts:
arnied/arnied/schedule.cpp

16 years agoAdded proper boost dependencies
Thomas Jarosch [Fri, 13 Feb 2009 16:42:10 +0000]
Added proper boost dependencies

16 years agoMerge branch 'boost-upgrade'
Thomas Jarosch [Fri, 13 Feb 2009 16:40:25 +0000]
Merge branch 'boost-upgrade'

16 years agoMerge branch 'firewall-design-update'
Thomas Jarosch [Thu, 12 Feb 2009 11:03:02 +0000]
Merge branch 'firewall-design-update'

16 years agoMerge branch 'arnied-clockchange' into intranator-next
Gerd von Egidy [Tue, 3 Feb 2009 11:27:11 +0000]
Merge branch 'arnied-clockchange' into intranator-next

16 years agoadd accessor functions and default constructor to WeekCron
Gerd von Egidy [Tue, 3 Feb 2009 11:00:41 +0000]
add accessor functions and default constructor to WeekCron

16 years agoprotect week.hpp against double-inclusion
Gerd von Egidy [Tue, 3 Feb 2009 10:34:01 +0000]
protect week.hpp against double-inclusion

16 years agosome more unit-tests, test coverage fairly complete now
Gerd von Egidy [Tue, 3 Feb 2009 10:24:54 +0000]
some more unit-tests, test coverage fairly complete now

16 years agosplit test_cron.cpp into test_cron_point and test_cron_interval
Gerd von Egidy [Tue, 3 Feb 2009 08:56:43 +0000]
split test_cron.cpp into test_cron_point and test_cron_interval

16 years agoimprove comment
Gerd von Egidy [Tue, 3 Feb 2009 08:48:24 +0000]
improve comment

16 years agofix unit-test (copy&paste-bug in the times)
Gerd von Egidy [Tue, 3 Feb 2009 08:46:32 +0000]
fix unit-test (copy&paste-bug in the times)

16 years agoadd even more interval-unit-tests. one is failing though, don't know why yet.
Gerd von Egidy [Fri, 30 Jan 2009 17:20:37 +0000]
add even more interval-unit-tests. one is failing though, don't know why yet.

16 years agoeven more (interval-) unit tests
Gerd von Egidy [Fri, 30 Jan 2009 11:04:43 +0000]
even more (interval-) unit tests

16 years agoAdded some safety checks to WeekCron. Updated StartHourStaysTheSameTill2038 unit...
Thomas Jarosch [Fri, 30 Jan 2009 09:34:10 +0000]
Added some safety checks to WeekCron. Updated StartHourStaysTheSameTill2038 unit test

16 years agoadd some more DST-unit-tests
Gerd von Egidy [Fri, 30 Jan 2009 08:52:58 +0000]
add some more DST-unit-tests

16 years agofound out how to reliably get the start of the day (without caring for DST),
Gerd v. Egidy [Thu, 29 Jan 2009 19:53:30 +0000]
found out how to reliably get the start of the day (without caring for DST),
calculating the calc_from-parameter in cases where the schedule has already happened today is now
unaffected by DST-changes

16 years agoAdded heavy unit test for WeekCron. Triggers glibc bug? Needs test with new one.
Thomas Jarosch [Thu, 29 Jan 2009 19:18:21 +0000]
Added heavy unit test for WeekCron. Triggers glibc bug? Needs test with new one.

16 years agofix bugs with dst-changes. maybe won't work for other DST-regimes
Gerd von Egidy [Thu, 29 Jan 2009 18:16:01 +0000]
fix bugs with dst-changes. maybe won't work for other DST-regimes
than Europe (e.g. US). So we'll need some other way to get the
start of the day.

16 years agofix unit-tests that were broken, mark dst-bug, add another unit-test for dst-bug
Gerd von Egidy [Thu, 29 Jan 2009 17:02:37 +0000]
fix unit-tests that were broken, mark dst-bug, add another unit-test for dst-bug

16 years agoMerge commit 'origin/arnied-clockchange' into arnied-clockchange
Thomas Jarosch [Wed, 28 Jan 2009 17:31:38 +0000]
Merge commit 'origin/arnied-clockchange' into arnied-clockchange

Conflicts:
libi2ncommon/src/cron.cpp
libi2ncommon/src/cron.hpp

16 years agosome tests for DST, some currently failing, maybe bug in glibc.
Thomas Jarosch [Wed, 28 Jan 2009 17:23:30 +0000]
some tests for DST, some currently failing, maybe bug in glibc.
more correct get_next_run interval-calculation, but no bug before

16 years agoRewrote Week::get_displaystring() and wrote unit test for it (before rewrite).
Thomas Jarosch [Wed, 28 Jan 2009 16:22:38 +0000]
Rewrote Week::get_displaystring() and wrote unit test for it (before rewrite).

16 years agoFix some signed/unsigned issues in Week
Thomas Jarosch [Wed, 28 Jan 2009 14:37:34 +0000]
Fix some signed/unsigned issues in Week

16 years agoMoved WEEK class to own file. Renamed to Week and adapted to I2n code style. Adapted...
Thomas Jarosch [Wed, 28 Jan 2009 14:00:07 +0000]
Moved WEEK class to own file. Renamed to Week and adapted to I2n code style. Adapted all client code. Added Week::is_valid(). Made constructor more exception safe.

16 years agofix casts in unit-test, return StNimmerleinsDay for never, take care of very short...
Thomas Jarosch [Wed, 28 Jan 2009 11:03:00 +0000]
fix casts in unit-test, return StNimmerleinsDay for never, take care of very short intervals

16 years agoMoved to i2n namespace. Constification. Calculate next_begin only once
Thomas Jarosch [Wed, 28 Jan 2009 10:24:40 +0000]
Moved to i2n namespace. Constification. Calculate next_begin only once

16 years agorefactor WeekCron: rename get_lastnow_point to _previousnow_
Thomas Jarosch [Wed, 28 Jan 2009 10:12:25 +0000]
refactor WeekCron: rename get_lastnow_point to _previousnow_

16 years agoAdd documentation, cosmetic changes
Thomas Jarosch [Wed, 28 Jan 2009 10:01:01 +0000]
Add documentation, cosmetic changes

16 years agoRenamed variables to match i2n code style
Thomas Jarosch [Wed, 28 Jan 2009 09:30:16 +0000]
Renamed variables to match i2n code style

16 years agofix off-by-one / half-open-interval on end of interval, add unit-tests
Thomas Jarosch [Wed, 28 Jan 2009 09:13:56 +0000]
fix off-by-one / half-open-interval on end of interval, add unit-tests

16 years agosome more unit-tests for time-points
Thomas Jarosch [Wed, 28 Jan 2009 08:50:11 +0000]
some more unit-tests for time-points

16 years agofix off-by-one at the end of an interval
Thomas Jarosch [Wed, 28 Jan 2009 08:38:51 +0000]
fix off-by-one at the end of an interval

16 years agoadd ideas for unit-tests
Gerd v. Egidy [Wed, 28 Jan 2009 01:39:07 +0000]
add ideas for unit-tests

16 years agoscheduling class can do intervals now, some fixes
Gerd v. Egidy [Wed, 28 Jan 2009 01:32:17 +0000]
scheduling class can do intervals now, some fixes

16 years agoadd class for weekly scheduling, intervals still missing
Gerd v. Egidy [Wed, 28 Jan 2009 00:06:36 +0000]
add class for weekly scheduling, intervals still missing

16 years agoMerge branch 'connd-syncbarrier'
Thomas Jarosch [Thu, 22 Jan 2009 10:37:45 +0000]
Merge branch 'connd-syncbarrier'

16 years agoAdded doxygen documentation
Thomas Jarosch [Fri, 16 Jan 2009 10:35:55 +0000]
Added doxygen documentation

16 years agoIncrease version
Thomas Jarosch [Mon, 12 Jan 2009 16:03:03 +0000]
Increase version

16 years agoMerge branch 'bsmtp-duplexer'
Gerd von Egidy [Mon, 22 Dec 2008 11:18:28 +0000]
Merge branch 'bsmtp-duplexer'

16 years agolibi2ncommon: (tomj) fix i2n::User and i2n::Group usage of uid/gid -1 (-1 is reserved...
Thomas Jarosch [Thu, 4 Dec 2008 14:14:35 +0000]
libi2ncommon: (tomj) fix i2n::User and i2n::Group usage of uid/gid -1 (-1 is reserved and ok)

16 years agolibi2ncommon: (tomj) added comment about broken User and Group "structs"
Thomas Jarosch [Tue, 18 Nov 2008 09:36:12 +0000]
libi2ncommon: (tomj) added comment about broken User and Group "structs"

16 years agolibi2ncommon: (tomj) fix buffer overflow in new syslog code
Thomas Jarosch [Tue, 18 Nov 2008 08:31:24 +0000]
libi2ncommon: (tomj) fix buffer overflow in new syslog code

16 years agolibi2ncommon: (tomj) increase version
Thomas Jarosch [Thu, 23 Oct 2008 07:27:35 +0000]
libi2ncommon: (tomj) increase version

16 years agolibi2ncommon: (reinhard) added method for retrieving the log file name.
Reinhard Pfau [Mon, 20 Oct 2008 09:25:30 +0000]
libi2ncommon: (reinhard) added method for retrieving the log file name.

16 years agolibi2ncommon: (reinhard) added method to ask if logging to log file is active. enable...
Reinhard Pfau [Mon, 20 Oct 2008 09:09:34 +0000]
libi2ncommon: (reinhard) added method to ask if logging to log file is active. enable_log_file(bool) now uses a default logfile if enabled without known log path.

16 years agolibi2ncommon: (reinhard) updated spacing for logfunc.
Reinhard Pfau [Mon, 20 Oct 2008 08:45:59 +0000]
libi2ncommon: (reinhard) updated spacing for logfunc.

16 years agolibi2ncommon: (reinhard) added reopen() method to logger module.
Reinhard Pfau [Mon, 22 Sep 2008 15:53:10 +0000]
libi2ncommon: (reinhard) added reopen() method to logger module.

16 years agolibi2ncommon: (reinhard) fixed the "var list does not vanish" problem.
Reinhard Pfau [Thu, 4 Sep 2008 14:19:43 +0000]
libi2ncommon: (reinhard) fixed the "var list does not vanish" problem.

16 years agolibsimpleio: (reinhard) added unit test for the "var does not vanish" problem.
Reinhard Pfau [Thu, 4 Sep 2008 14:10:12 +0000]
libsimpleio: (reinhard) added unit test for the "var does not vanish" problem.

16 years agolibsimpleio: (reinhard) copied unit test for global config module from connd.
Reinhard Pfau [Thu, 4 Sep 2008 14:06:07 +0000]
libsimpleio: (reinhard) copied unit test for global config module from connd.

16 years agoarnied, libi2ncommon, arnielizer, ui: (tomj) moved common xml code to own lib2ncommon...
Thomas Jarosch [Tue, 2 Sep 2008 11:24:46 +0000]
arnied, libi2ncommon, arnielizer, ui: (tomj) moved common xml code to own lib2ncommon_xml library, put functions in I2n namespace

16 years agolibi2ncommon: (gerd) add monotonic_clock_gettime_nano()
Gerd v. Egidy [Thu, 28 Aug 2008 11:35:25 +0000]
libi2ncommon: (gerd) add monotonic_clock_gettime_nano()

16 years agolibi2ncommon: (reinhard) added global_config module (as separate lib and package...
Reinhard Pfau [Tue, 26 Aug 2008 10:50:09 +0000]
libi2ncommon: (reinhard) added global_config module (as separate lib and package: libi2ncommon_config)

16 years agolibi2ncommon: (reinhard) added configdata and configfile module from connd.
Reinhard Pfau [Tue, 26 Aug 2008 09:59:29 +0000]
libi2ncommon: (reinhard) added configdata and configfile module from connd.

16 years agolibi2ncommon: (reinhard) workaround for glibc weirdness..
Reinhard Pfau [Mon, 18 Aug 2008 12:09:17 +0000]
libi2ncommon: (reinhard) workaround for glibc weirdness..

16 years agolibi2ncommon: (tomj) add missing default return value to drop_root_privileges()
Thomas Jarosch [Tue, 12 Aug 2008 15:30:34 +0000]
libi2ncommon: (tomj) add missing default return value to drop_root_privileges()

16 years agolibi2ncommon: (tomj) unit tests for normalize_path() corner cases
Thomas Jarosch [Wed, 6 Aug 2008 16:11:50 +0000]
libi2ncommon: (tomj) unit tests for normalize_path() corner cases

16 years agolibi2ncommon: (reinhard) changes for g++ 4.3.1
Reinhard Pfau [Fri, 1 Aug 2008 12:47:15 +0000]
libi2ncommon: (reinhard) changes for g++ 4.3.1

16 years agolibi2ncommon: (reinhard) added pointer_func and signalfunc modules.
Reinhard Pfau [Tue, 29 Jul 2008 09:39:23 +0000]
libi2ncommon: (reinhard) added pointer_func and signalfunc modules.

16 years ago[MERGE] libi2ncommon: (gerd) add WEEK::set(daystring)
Thomas Jarosch [Tue, 8 Jul 2008 12:28:13 +0000]
[MERGE] libi2ncommon: (gerd) add WEEK::set(daystring)

16 years ago[MERGE] libi2ncommon: (reinhard) added support for POSIX.1b realtime and monotonic...
Thomas Jarosch [Tue, 8 Jul 2008 12:27:20 +0000]
[MERGE] libi2ncommon: (reinhard) added support for POSIX.1b realtime and monotonic clock to timefunc.

16 years ago[MERGE] libi2ncommon: (reinhard) added contains_exact method to interval classes.
Thomas Jarosch [Tue, 8 Jul 2008 11:43:40 +0000]
[MERGE] libi2ncommon: (reinhard) added contains_exact method to interval classes.

16 years ago[MERGE] libi2ncommon: (reinhard) added operator!= to Interval; aded some doc.
Thomas Jarosch [Tue, 8 Jul 2008 11:42:05 +0000]
[MERGE] libi2ncommon: (reinhard) added operator!= to Interval; aded some doc.

16 years ago[MERGE] libi2ncommon: (reinhard) added getter to WEEK...
Thomas Jarosch [Tue, 8 Jul 2008 11:40:21 +0000]
[MERGE] libi2ncommon: (reinhard) added getter to WEEK...