Fix 'occurred' typo

[bpdyndnsd] / src / service_easydns.cpp

diff --git a/src/service_easydns.cpp b/src/service_easydns.cpp
index 66d96ab..d598d64 100644 (file)
--- a/src/service_easydns.cpp
+++ b/src/service_easydns.cpp
@@ -7,8 +7,8 @@
  * @license GPLv2
 */
 
-#include "service_easydns.h"
-#include "util.h"
+#include "service_easydns.hpp"
+#include "util.hpp"
 
 #include <time.h>
 #include <boost/foreach.hpp>
@@ -33,10 +33,10 @@ ServiceEasydns::ServiceEasydns()
  * @param _login The login name.
  * @param _password The corresponding password.
  */
-ServiceEasydns::ServiceEasydns(const string& _protocol, const string& _hostname, const string& _login, const string& _password, const Logger::Ptr& _logger, const int _update_interval, const int _max_updates_within_interval, const int _dns_cache_ttl, const string& _proxy, const int _proxy_port)
+ServiceEasydns::ServiceEasydns(const string& _protocol, const string& _hostname, const string& _login, const string& _password, const Logger::Ptr& _logger, const int _update_interval, const int _max_updates_within_interval, const int _max_equal_updates_in_succession, const int _dns_cache_ttl, const string& _proxy, const int _proxy_port)
 {
     if ( _update_interval == -1 )        // If _update_interval is default po::option_desc (not specified via config)
-        set_update_interval(10);              // use default protocol value
+        set_update_interval(12);              // use default protocol value
     else
         set_update_interval(_update_interval);
 
@@ -45,6 +45,11 @@ ServiceEasydns::ServiceEasydns(const string& _protocol, const string& _hostname,
     else
         set_max_updates_within_interval(_max_updates_within_interval);
 
+    if ( _max_equal_updates_in_succession == -1 )
+        set_max_equal_updates_in_succession(2);
+    else
+        set_max_equal_updates_in_succession(_max_equal_updates_in_succession);
+
     if ( _dns_cache_ttl == -1 )
         set_dns_cache_ttl(1200);
     else
@@ -57,8 +62,7 @@ ServiceEasydns::ServiceEasydns(const string& _protocol, const string& _hostname,
     set_logger(_logger);
 
     // create http helper class
-    HTTPHelper::Ptr _http_help(new HTTPHelper(_logger,_proxy,_proxy_port,_login,_password));
-    HTTPHelp.swap(_http_help);
+    HTTPHelp = HTTPHelper::Ptr(new HTTPHelper(_logger,_proxy,_proxy_port,_login,_password));
 
     // extract domain part from hostname
     list<string> host_domain_part = separate_domain_and_host_part(get_hostname());
@@ -179,41 +183,51 @@ list<string> ServiceEasydns::separate_domain_and_host_part(const string& fqdn) c
  * @param ip IP Address to set.
  * @return 0 if all is fine, -1 otherwise.
  */
-int ServiceEasydns::perform_update(const std::string& ip)
+Service::UpdateErrorCode ServiceEasydns::perform_update(const std::string& ip)
 {
     string url = BaseUrl;
     url.append(ip);
 
-    long http_status_code = HTTPHelp->http_get(url);
-
-    get_logger()->print_http_status_code(url,http_status_code);
-
-    // HTTP operation completed successful.
-    // Now we have to parse the data received by curl,
-    // cause http status code is not significant for easydns update errors
-    if ( http_status_code == 200 )
+    if ( HTTPHelp->is_initialized() )
     {
-        // Get the received http data.
-        string curl_data = HTTPHelp->get_curl_data();
-        string status_code = Util::parse_status_code(curl_data,"\n");
+        long http_status_code = HTTPHelp->http_get(url);
 
-        if ( status_code == "NOERROR" )
-        {
-            return 0;
-        }
-        else if ( status_code == "NOACCESS" )
+        get_logger()->print_http_status_code(url,http_status_code);
+
+        // HTTP operation completed successful.
+        // Now we have to parse the data received by curl,
+        // cause http status code is not significant for easydns update errors
+        if ( http_status_code == 200 )
         {
-            get_logger()->print_service_not_authorized(url,get_login(),get_password());
+            // Get the received http data.
+            string curl_data = HTTPHelp->get_curl_data();
+            string status_code = Util::parse_status_code(curl_data,"\n");
+
+            if ( status_code == "NOERROR" )
+            {
+                return UpdateOk;
+            }
+            else if ( status_code == "NOACCESS" )
+            {
+                get_logger()->print_service_not_authorized(url,get_login(),get_password());
+                return NotAuth;
+            }
+            else
+            {
+                get_logger()->print_update_failure(url, curl_data);
+                return UpdateError;
+            }
         }
         else
         {
-            get_logger()->print_update_failure(url, curl_data);
+            get_logger()->print_update_failure(url,http_status_code);
         }
     }
     else
     {
-        get_logger()->print_update_failure(url,http_status_code);
+        get_logger()->print_httphelper_not_initialized();
+        HTTPHelp->re_initialize();
     }
 
-    return -1;
+    return GenericError;
 }