Re: Pull Request Process

[Harrison Marcks <hmarcks@xxxxxxxxxxxxxxxxxxxx>]

Hi Andrew,

I used `git send-email` to submit my patch - though NB it may take a while to get looked at by the owner.

How to use `git send-email`? I have these two lines in my notes:

 2001  git format-patch -v 3 HEAD~~ --subject-prefix="PATCH Fixed first device failure in open_desc function"
 2002  git send-email --annotate --to libftdi@xxxxxxxxxxxxxxxxxxxxxxx v3-000*.patch

You may have to read around to tweak it thoroughly.

If you cba at all: use the patch as a template. So copy the patch title as the email subject, then put the rest into the body.

Cheers,

HarryM

On Wed, 29 Nov 2023 at 02:27, Andrew O'Mahony <andrewsomahony@xxxxxxxxx> wrote:

Hello,

I've just joined the group and would like to just make sure I
understand the patching process:

I have cloned the code into my own repo, made my changes, and can
generate a pull request.

Do I put the pull request in this group?  Do I need a specific subject line?

Thanks,
Andrew

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

--

Harrison James 'Harry' Marcks, Engineer

https://www.thegoodpenguin.co.uk

The Good Penguin Ltd is a company registered in England and Wales with company number 12374667 and VAT number 341687879. Registered office: The Good Penguin Ltd, Westcott, Glasllwch Lane, Newport, NP20 3PS.

---

libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx