libftdi Archives

Subject: Re: [PATCH] ftdi_stream: fix timeout setting

From: Matthias Klein <matthias@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
Date: Fri, 01 Sep 2023 10:15:18 +0200
Hi Thomas,

Did you experience an integer overflow with large timeout values
or what was the motivation for this change?

I could not start example/stream_test.
In ftdi.c:96 ftdi->usb_read_timeout is initialized with 5000, and in ftdi_stream.c:248 passed to libusb_handle_events_timeout().
There it crashed for me because 5000 * 1000 is greater than 1,000,000.

Here is the maximum of 1,000,000 described: https://www.gnu.org/software/libc/manual/html_node/Time-Types.html

Best regards,
Matthias

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
Current Thread