Hi Brian!
You wrote on Wed, May 18, 2022 at 02:50:08PM +0000:
> Hi again, I now understand how to set the eeprom chip in the config
> ("eeprom_type=0x56"), so I removed that hacky line from the patch. I still
> don't know what 0x8A is used for but I learnt you can use user_data_addr
> and user_data_file to manually set this byte in the config.
thanks for the patch! It looks correct to me, especially given
that the other chips have the group1 drive at "buf[0x0c] >> 4".
I looked around other parts of libftdi for "group1_"
and I think we also need to change this one when parsing an eeprom:
*************************************
else if (ftdi->type == TYPE_232H)
{
..
eeprom->group1_drive = buf[0x0d] & DRIVE_16MA; /*
not a bitflag */
eeprom->group1_schmitt = !!(buf[0x0d] & IS_SCHMITT);
eeprom->group1_slew = !!(buf[0x0d] & SLOW_SLEW);
}
*************************************
Can you confirm?
For now I put your patch on an extra branch called "ft232h-group1"
so we can apply any further fixup patches before moving it to "master".
Cheers,
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|