libftdi Archives

Subject: Re: [PATCH v2,1/1] cmake: do not check for g++ when FTDIPP is disabled

From: Aurelien Jarno <aurelien@xxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>, Samuel Martin <s.martin49@xxxxxxxxx>
Date: Mon, 13 Jul 2020 12:13:36 +0200
Hi,

On 2020-01-24 09:29, Thomas Jarosch wrote:
> Hi Fabrice,
> 
> You wrote on Tue, Jan 21, 2020 at 11:05:27PM +0100:
> > Signed-off-by: Samuel Martin <s.martin49@xxxxxxxxx>
> > [Retrieved (and slightly updated) from:
> > https://git.buildroot.net/buildroot/tree/package/libftdi1/0003-cmake-do-not-check-for-g-when-FTDIPP-is-disabled.patch]
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
> > ---
> > Changes v1 -> v2:
> >  - Move project statement from ftdipp/CMakeLists.txt to CMakeLists.txt.
> >    This will avoid a build failure while building C++ examples.
> > 
> >  CMakeLists.txt | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> applied, thanks!
> 
> I've tested building with FTDIPP set to ON and OFF.

It happens that this patch as in impact in the paths used in the
library:
- example.conf ends up being installed in:
  /usr/local/share/doc/libftdipp1/example.conf
  instead of
  /usr/local/share/doc/libftdi1/example.conf
- more problematic the libftdi1.pc config file defines the include path
  as /usr/local/include/libftdipp1 while the ftdi.h file is actually
  installed in /usr/local/include/libftdi1

It seems that defining the project as "project(libftdi1 C CXX)" when
FTDIPP is enabled fixed the issue.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@xxxxxxxxxxx                 http://www.aurel32.net

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread