Hello Thomas,
Le mer. 15 janv. 2020 à 20:40, Thomas Jarosch
<thomas.jarosch@xxxxxxxxxxxxx> a écrit :
>
> Hi Fabrice,
>
> You wrote on Wed, Oct 02, 2019 at 05:28:33PM +0200:
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index 71857d0..1e26ed4 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -1,5 +1,5 @@
> > # Project
> > -project(libftdi1)
> > +project(libftdi1 C)
> > set(MAJOR_VERSION 1)
> > set(MINOR_VERSION 4)
> > set(PACKAGE libftdi1)
> > diff --git a/ftdipp/CMakeLists.txt b/ftdipp/CMakeLists.txt
> > index 2983d3d..37abbe3 100644
> > --- a/ftdipp/CMakeLists.txt
> > +++ b/ftdipp/CMakeLists.txt
> > @@ -1,5 +1,7 @@
> > # vim: ts=2:sw=2:sts=2
> >
> > +project(libftdipp1 C CXX)
>
> thanks for upstreaming this patch.
>
> I checked it some weeks ago and I was unsure regarding
> the additional definition of project() in CMakeLists.txt.
>
> A search on the net didn't give a definitive answer if it's
> ok to call project() twice or more in a cmake project.
>
> Today I tried the patch again with Fedora 31 and it fails:
>
> $ cmake -DFTDIPP=ON ../
> -- Build type: RelWithDebInfo
> -- Detected git snapshot version: v1.4-27-g725f9a4
> -- Building ftdi_eeprom
> -- Summary of build options:
>
> Build static libs: ON
> Build C++ bindings: ON
> Build Python bindings: OFF
> Build ftdi_eeprom: ON
> Build examples: ON
> Build tests: OFF
> Build API documentation: OFF
>
> -- Configuring done
> CMake Error: Error required internal CMake variable not set, cmake may not be
> built correctly.
> Missing variable is:
> CMAKE_CXX_COMPILE_OBJECT
> CMake Error: Error required internal CMake variable not set, cmake may not be
> built correctly.
> Missing variable is:
> CMAKE_CXX_LINK_EXECUTABLE
> -- Generating done
> CMake Generate step failed. Build files cannot be regenerated correctly.
>
>
> Environment: Fedora 31 / cmake version 3.16.1 / gcc 9.2.1
>
>
> Without the patch compilation is fine, tried -DFTIPP=ON and -DFTDIPP=OFF.
>
> Any idea how to proceed here?
I found the issue, it is due to EXAMPLES that also require C++.
As a result, the project statement must be moved from
ftdipp/CMakeLists.txt to CMakeLists.txt. I can send a v2 if you want.
>
> Cheers,
> Thomas
Best Regards,
Fabrice
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx
|
