libftdi Archives

Subject: [PATCH] Use BM/R series baud rate computation for FT230X

From: Joe Zbiciak <intvnut@xxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Sat, 13 Aug 2016 12:49:17 -0700
I've reformatted my suggested tweak below as a proper git patch.

commit 3f1f92238eacf6019e985c90013d7d8e1bdf6281
Author: Joe Zbiciak <intvnut@xxxxxxxxx>
Date:   Sat Aug 13 12:46:16 2016 -0700

    Use BM/R series baud rate computation for FT230X.
    
    The current code uses the AM series baud rate computation for FT230X,
    and this results in incorrect divisor calculation for high baud rates.
    Use the BM/R series logic instead.
    
    This matches the corresponding code paths in the Linux kernel ftdi_sio
    driver.  See ftdi_sio.c:1323 here:
    
    
    Specifically attempts to set 2000000 on an FT230X fail currently due to
    the if-statement at ftdi.c:1106.  The computed divisor (12) gets clamped
    to 16, and thus the for-loop it's in doesn't converge on a usable divisor.
    
    The if-statement at ftdi.c:1152 never fires, as the if-statement at
    ftdi.c:1106 in the for-loop precludes a divisor of 12 (which is required
    for *encoded_divisor to become 0x4001).


On Fri, Aug 12, 2016 at 10:23 PM, Joe Zbiciak <intvnut@xxxxxxxxx> wrote:
Hello,

I'm trying to use an FT230X with libftdi. 

It appears libftdi doesn't correctly compute the FT230X baud rate divisor.  AFAICT, it's supposed to be computed the same as the FT232R and related devices.  I determined this by looking at the corresponding code in the Linux kernel's fdti_sio.c.

I patched my local copy by modifying line 1255 in ftdi.c.  It currently reads as follows:

else if ((ftdi->type == TYPE_BM) || (ftdi->type == TYPE_2232C) || (ftdi->type == TYPE_R ))

I changed it to read:

else if ((ftdi->type == TYPE_BM) || (ftdi->type == TYPE_2232C) || (ftdi->type == TYPE_R) || (ftdi->type == TYPE_230X))

Prior to the change, I was unable to set a baud rate of 2000000.  After the change, it worked correctly.  I haven't tested other baud rates.  I did, however, compare the code to the Linux kernel code, and it uses the same baud rate computation for the X series as it does for the BM and R series.

I haven't seen any discussion of this issue recently in the list archives.  I did find one thread from over 2 years ago, but it didn't end with a fix.


--



--


libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx


Attachment: 0001-Use-BM-R-series-baud-rate-computation-for-FT230X.patch
Description: Binary data

Current Thread