libftdi Archives

Subject: Re: libftdi patches : [Patch 1/5] : Prevent possible division by 0

From: Nathael Pajani <nathael.pajani@xxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Wed, 10 Apr 2013 10:26:27 +0200
Hi,

No, you're right, actually there's no problem. But should this function be used 
elsewhere
in the future, it may become a problem. Better to check for it in the function, 
even if
today it's a double check.


Le 10/04/2013 10:00, Thomas Jarosch a écrit :
> Hi Nathael,
> 
> regarding this patch, can you tell me why it is needed?
> 
> ftdi_convert_baudrate() already checks if the baudrate is zero.
> ftdi_to_clkbits() is only used internally and not exported via the API.
> 
> Did I miss something?
> 
> Cheers,
> Thomas
> 
> 
> --
> libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
> To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   
> 


-- 
Nathaël PAJANI
ED3L - Étude et Développement - Linux et Logiciels Libres
Internet : http://www.ed3l.fr

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread