libftdi Archives

Subject: Re: libftdi patches : [Patch 3/5] : Removes compiler warnings on signed comparison

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Wed, 10 Apr 2013 10:16:37 +0200
Hi Nathael,

I've applied this patch except this part:

@@ -1115,7 +1115,7 @@ static int ftdi_to_clkbits_AM(int baudrate, unsigned long 
*encoded_divisor)
    AM Type chips have only four fractional subdivisors at value[15:14]
    for subdivisors 0, 0.5, 0.25, 0.125
 */
-static int ftdi_to_clkbits(int baudrate, unsigned int clk, int clk_div, 
unsigned long *encoded_divisor)
+static int ftdi_to_clkbits(unsigned int baudrate, unsigned int clk, int 
clk_div, unsigned long *encoded_divisor)
 {
     static const char frac_code[8] = {0, 3, 2, 4, 1, 5, 6, 7};
     int best_baud = 0;



That would be wrong since all the other API functions dealing
with the baudrate use a signed type. The fix should look different.


btw: It would be much easier for me if you send the patches
inline via email. "git am" does not recognize the patch format
and "git apply" does not create a commit automatically.

Also it's easier to comment on certain parts of the code :)

Thanks!
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread