libftdi Archives

Subject: Re: [PATCH 0/3] various ftdi_eeprom fixes

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Cc: Anders Larsen <al@xxxxxxxxxxx>
Date: Sat, 7 Jul 2012 14:47:44 +0200
Hi Anders,

On Tuesday, 3. July 2012 23:24:04 Anders Larsen wrote:
> On 2012-04-13 15:01:44, Thomas Jarosch wrote:
> > Here you hardcode "256" twice into the code. Any chance you can turn
> > this into a define or "const int"?
> > 
> > Also we should check for fread() errors if we
> > are going to touch this piece of code :)
> 
> I've updated Patch 1/3 (ftdi_eeprom: Added config value "eeprom_type")
> to address your concerns.

Thanks for coming back with the changes, all applied.

Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread