libftdi Archives

Subject: Re: [1.0] Try to inihibit programming EEPROM with data for a different device

From: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Mon, 4 Jul 2011 09:47:30 +0200
Hello Uwe,

I'm not sure about this patch: It breaks the ftdi_eeprom tool :o)
The eeprom is first initialized   and later on written out.
Might also break other eeprom handling code.

> +    if (ftdi->usb_dev == NULL)
> +        ftdi_error_return(-3, "No connected device or device not yet
> opened"); +
>      eeprom = ftdi->eeprom;
>      memset(eeprom, 0, sizeof(struct ftdi_eeprom));
>  

If we go a route like this, we should to the memset(eeprom) first.

Last note: 
(- Inserting a new field into the eeprom struct is fine right now
   as the ABI is not stable yet).


Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx   

Current Thread