libftdi Archives

Subject: Re: [libftdi-1.0] Limit read buffer chunksize to 16384 on Linux

From: Jie Zhang <jzhang918@xxxxxxxxx>
To: libftdi@xxxxxxxxxxxxxxxxxxxxxxx
Date: Sun, 14 Feb 2010 19:17:58 +0800
On Sun, Feb 14, 2010 at 5:58 PM, Jim Paris <jim@xxxxxxxx> wrote:
>> +#ifdef __linux__
>> +    /* We can't set readbuffer_chunksize larger than MAX_BULK_BUFFER_LENGTH,
>> +       which is defined in libusb-1.0.  Otherwise, each USB read request 
>> will
>> +       be divided into multiple URBs.  This will cause issues on Linux 
>> kernel
>> +       older than 2.6.32.  */
>> +    if (chunksize > 16384)
>> +        chunksize = 16384;
>
> Shouldn't this be
>
>> +    if (chunksize > MAX_BULK_BUFFER_LENGTH)
>> +        chunksize = MAX_BULK_BUFFER_LENGTH;
>
MAX_BULK_BUFFER_LENGTH is a macro defined in an internal header file
in libusb. So we can't use it here.


Jie

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxx

Current Thread