X-Git-Url: http://developer.intra2net.com/git/?p=libt2n;a=blobdiff_plain;f=src%2Fsocket_client.cpp;fp=src%2Fsocket_client.cpp;h=fca01d144ec3de540fc3d02e50713e8d8a0febbd;hp=d8dc413aeae469529ab80a35e43b2288adfb9875;hb=56f3994d74dbc36d10bfa83b50b016bf269ac563;hpb=c72238fb7fc6eb081c2a0bc95fff369c760343f4 diff --git a/src/socket_client.cpp b/src/socket_client.cpp index d8dc413..fca01d1 100644 --- a/src/socket_client.cpp +++ b/src/socket_client.cpp @@ -66,6 +66,7 @@ socket_client_connection::socket_client_connection(int _port, const std::string& { lastErrorMsg=e.what(); LOGSTREAM(debug,"tcp connect error: " << lastErrorMsg); + // FIXME: Don't call virtual function in constructor. Currently not dangerous but bad design. close(); } @@ -94,7 +95,7 @@ socket_client_connection::socket_client_connection(const std::string& _path, { lastErrorMsg=e.what(); LOGSTREAM(debug,"unix connect error: " << lastErrorMsg); - // FIXME: Calls virtual function close in constructor + // FIXME: Don't call virtual function in constructor. Currently not dangerous close(); } @@ -107,7 +108,7 @@ socket_client_connection::socket_client_connection(const std::string& _path, */ socket_client_connection::~socket_client_connection() { - close(); + // Destructor of socket_handler will close the socket! }