From 80b0e508f15731974f77af17496991defdcf9e90 Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Mon, 18 Oct 2010 11:47:33 +0200 Subject: [PATCH] Add TODO entry about nochg response --- docs/TODO | 4 ++++ src/service_dyndns.cpp | 3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/docs/TODO b/docs/TODO index c982fa9..5c5c23f 100644 --- a/docs/TODO +++ b/docs/TODO @@ -15,6 +15,10 @@ - Configurable CA certificate handling Nice to have: +- Handle "nochg" responses (f.e. from service dyndns) + by outputing a warning to the user that more + than one client might be active. + - webcheck mode: Cache last known IP We only determine the current IP every "webcheck_interval" to prevent server trashing. diff --git a/src/service_dyndns.cpp b/src/service_dyndns.cpp index 1ab80f6..8e49c53 100644 --- a/src/service_dyndns.cpp +++ b/src/service_dyndns.cpp @@ -124,6 +124,9 @@ int ServiceDyndns::perform_update(const std::string& ip) // Get the received http data. string curl_data = HTTPHelp->get_curl_data(); + // Note: We don't handle "nochg" as this shouldn't happen + // if only one client is active. + if ( curl_data == good ) { return 0; -- 1.7.1