From 79782fa91bff603ce4287d378aeea4944ff5081d Mon Sep 17 00:00:00 2001
From: Philipp Gesang <philipp.gesang@intra2net.com>
Date: Thu, 16 Mar 2017 17:06:28 +0100
Subject: [PATCH] redo transition between objects in crypto layer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

When encrypting, the ciphertext size isn’t known beforehand.
Likewise, the file name isn’t available when initializing the
decryption of a file.
---
 deltatar/crypto.py |   25 +++++++++++--------------
 1 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/deltatar/crypto.py b/deltatar/crypto.py
index 2ac588b..2d84ccc 100755
--- a/deltatar/crypto.py
+++ b/deltatar/crypto.py
@@ -93,6 +93,7 @@ HDR_OFF_PARAMVERSION = HDR_OFF_VERSION      + I2N_HDR_SIZE_VERSION
 HDR_OFF_NACL         = HDR_OFF_PARAMVERSION + I2N_HDR_SIZE_PARAMVERSION
 HDR_OFF_IV           = HDR_OFF_NACL         + I2N_HDR_SIZE_NACL
 HDR_OFF_CTSIZE       = HDR_OFF_IV           + I2N_HDR_SIZE_IV
+HDR_CTSIZE_DUMMY     = 0xffffFFFFffffFFFF
 
 FMT_UINT16_LE = "<H"
 FMT_UINT64_LE = "<Q"
@@ -168,7 +169,7 @@ def hdr_read_stream (instr):
 
 def hdr_from_params (version, paramversion, nacl, iv, ctsize=None):
     if ctsize is None:
-        ctsize = 0xffffFFFFffffFFFF # dummy, overwritten later
+        ctsize = HDR_CTSIZE_DUMMY # dummy, overwritten later
     buf  = bytearray (I2N_HDR_SIZE)
     bufv = memoryview (buf)
 
@@ -312,10 +313,6 @@ class Crypto (object):
         self.pfx          = pfx
 
 
-    def next (self, aad=None, iv=None):
-        self.aes.authenticate_additional_data (aad)
-
-
     def process (self, buf):
         self.aes.update (buf)
 
@@ -333,17 +330,17 @@ class Encrypt (Crypto):
         return struct.pack("<8sL", self.pfx, self.cnt % 0xffFFffFF)
 
 
-    def next (self, filename, ctsize):
+    def next (self, filename):
         self.cnt += 1
-        aad = "%.20x|%s" % (ctsize, filename)
-        iv = iv_make()
+        aad = "%s" % filename
+        iv = self.iv_make()
         self.aes = Cipher \
                         ( algorithms.AES (self.key)
                         , modes.GCM (iv)
                         , backend = default_backend ()) \
                         .encryptor ()
 
-        return super().next(aad)
+        return self.aes.authenticate_additional_data (aad)
 
 
     def done (self):
@@ -358,16 +355,14 @@ class Decrypt (Crypto):
         super().__init__ (password, paramversion, nacl)
 
 
-    def next (self, filename, hdr):
+    def next (self, hdr):
         self.cnt += 1
-        aad = "%0.20x|%s" % (hdr["ctsize"], filename)
         print("I2N: got header “%s”" % crypto.hdr_fmt (hdr))
         self.aes = Cipher \
                         ( algorithms.AES (key)
                         , modes.GCM (hdr["iv"])
                         , backend = default_backend ()) \
                         . decryptor ()
-        return super().next(aad)
 
 
     def next_in_source (self, tarinfo, source):
@@ -375,10 +370,12 @@ class Decrypt (Crypto):
         if ok is False:
             raise DecryptionError("Irrecoverable error reading header from "
                                   "%r" % source)
-        return self.next(tarinfo.name, hdr)
+        return self.next(hdr)
 
 
-    def done (self, tag):
+    def done (self, filename, tag):
+        aad = "%s" % filename
+        self.aes.authenticate_additional_data (aad)
         return self.aes.finalize_with_tag (tag)
 
 
-- 
1.7.1