From 6827496c3331adaae8521e9032f50d2665cfb6ce Mon Sep 17 00:00:00 2001 From: Guilherme Maciel Ferreira Date: Fri, 25 Mar 2011 10:02:51 +0100 Subject: [PATCH] Renamed PingAnalyzer's update_ping_failed_statistics() to analyze_ping_failed_count() --- src/ping/pinganalyzer.cpp | 5 +++-- src/ping/pinganalyzer.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ping/pinganalyzer.cpp b/src/ping/pinganalyzer.cpp index 83ae653..fc3ee52 100644 --- a/src/ping/pinganalyzer.cpp +++ b/src/ping/pinganalyzer.cpp @@ -112,17 +112,18 @@ void PingAnalyzer::increase_ping_failed_count() { ++PingsFailedCount; - update_ping_failed_statistics(); + analyze_ping_failed_count(); BOOST_ASSERT( ( 0 <= PingsFailedCount ) && ( PingsFailedCount <= PingsPerformedCount ) ); } -void PingAnalyzer::update_ping_failed_statistics() +void PingAnalyzer::analyze_ping_failed_count() { BOOST_ASSERT( ( 0 <= LimitPingFailPercentage ) && ( LimitPingFailPercentage <= 100 ) ); BOOST_ASSERT( ( 0 <= PingsFailedCount ) && ( PingsFailedCount <= PingsPerformedCount ) ); int limit_ping_fail_absolute = LimitPingFailPercentage / 100; // TODO possible precision loss, check with care + // keep a boolean variable because the PingsFailedCount can be reseted ExceededPingFailedCountLimit = ( PingsFailedCount > limit_ping_fail_absolute ); } diff --git a/src/ping/pinganalyzer.h b/src/ping/pinganalyzer.h index f59e339..0385b41 100644 --- a/src/ping/pinganalyzer.h +++ b/src/ping/pinganalyzer.h @@ -36,7 +36,7 @@ private: void reset_ping_counters(); void increase_ping_performed_count(); void increase_ping_failed_count(); - void update_ping_failed_statistics(); + void analyze_ping_failed_count(); private: std::string HostAddress; -- 1.7.1