From: Plamen Dimitrov Date: Tue, 26 Mar 2019 07:30:50 +0000 (+0800) Subject: Define new capture output flag for python 3.7 which is false by default X-Git-Tag: v1.5~7^2~3 X-Git-Url: http://developer.intra2net.com/git/?a=commitdiff_plain;h=d3e8a5f3c753f2c99d2a466e047358afa94603a5;p=pyi2ncommon Define new capture output flag for python 3.7 which is false by default This is a bad indicator of the backwards compatibility of minor versions since adding the flag with a default like this would probably break a lot of code down there. Sometimes it seems that python developers are not really concerned with how many things they break in their minors. --- diff --git a/src/arnied_wrapper.py b/src/arnied_wrapper.py index 9a39d62..c2ba2cc 100644 --- a/src/arnied_wrapper.py +++ b/src/arnied_wrapper.py @@ -103,7 +103,7 @@ def run_cmd(cmd="", ignore_errors=False, vm=None, timeout=60): if sys.version_info.major <= 3 and sys.version_info.minor < 5: return call_helpers.subprocess_run(cmd, check=not ignore_errors, shell=True) else: - return subprocess.run(cmd, check=not ignore_errors, shell=True) + return subprocess.run(cmd, check=not ignore_errors, shell=True, capture_output=True) def verify_running(process='arnied', timeout=60, vm=None):