From: Guilherme Maciel Ferreira <guilherme.maciel.ferreira@intra2net.com>
Date: Fri, 15 Apr 2011 12:10:01 +0000 (+0200)
Subject: Non-virtual destructors for classes that are unlikely to be base classes
X-Git-Tag: v1.0~76
X-Git-Url: http://developer.intra2net.com/git/?a=commitdiff_plain;h=a86e8ddcb31a99f6a840b5865a016b40525a9ac9;p=pingcheck

Non-virtual destructors for classes that are unlikely to be base classes
---

diff --git a/src/config/host.h b/src/config/host.h
index e2cee88..ef0adf0 100644
--- a/src/config/host.h
+++ b/src/config/host.h
@@ -16,7 +16,7 @@ class Host
 {
 public:
     Host( std::string address );
-    virtual ~Host();
+    ~Host();
 
     std::string get_address() const;
     void set_address( const std::string &address );
diff --git a/src/dns/dnsresolver.h b/src/dns/dnsresolver.h
index b551b6b..30764b0 100644
--- a/src/dns/dnsresolver.h
+++ b/src/dns/dnsresolver.h
@@ -14,7 +14,7 @@ class DnsResolver
 {
 public:
     explicit DnsResolver( const std::string &dns_address );
-    virtual ~DnsResolver();
+    ~DnsResolver();
 
     bool resolve();
     int get_resolved_ip_count() const;
diff --git a/src/dns/hostaddress.h b/src/dns/hostaddress.h
index 1185fa1..061b798 100644
--- a/src/dns/hostaddress.h
+++ b/src/dns/hostaddress.h
@@ -14,7 +14,7 @@ class HostAddress
 public:
     HostAddress();
     HostAddress( std::string ip, int ttl );
-    virtual ~HostAddress();
+    ~HostAddress();
 
     std::string get_ip() const;
     void set_ip( std::string ip );
diff --git a/src/host/hoststatusanalyzer.h b/src/host/hoststatusanalyzer.h
index 0283cb5..884a8b5 100644
--- a/src/host/hoststatusanalyzer.h
+++ b/src/host/hoststatusanalyzer.h
@@ -24,7 +24,7 @@ public:
             const int ping_fail_percentage_limit,
             const boost::shared_ptr<LinkStatusAnalyzer> link_analyzer
     );
-    virtual ~HostStatusAnalyzer();
+    ~HostStatusAnalyzer();
 
     void set_resolved_ip_count( const int resolved_ip_count );
     bool exceeded_ping_failed_limit() const;
diff --git a/src/host/pinginterval.h b/src/host/pinginterval.h
index 0676921..f76272c 100644
--- a/src/host/pinginterval.h
+++ b/src/host/pinginterval.h
@@ -15,6 +15,7 @@ class PingInterval
 {
 public:
     PingInterval( T interval );
+    ~PingInterval();
 
     operator T();
 
@@ -41,6 +42,11 @@ template<typename T>
     }
 
 template<typename T>
+    PingInterval<T>::~PingInterval()
+    {
+    }
+
+template<typename T>
     PingInterval<T>::operator T()
     {
         return Interval;
diff --git a/src/host/pingscheduler.h b/src/host/pingscheduler.h
index 7f6f90b..14a549d 100644
--- a/src/host/pingscheduler.h
+++ b/src/host/pingscheduler.h
@@ -31,7 +31,7 @@ public:
             const int ping_fail_percentage_limit,
             boost::shared_ptr<LinkStatusAnalyzer> link_analyzer
     );
-    virtual ~PingScheduler();
+    ~PingScheduler();
 
     bool start_pinging();
 
diff --git a/src/link/linkstatusanalyzer.h b/src/link/linkstatusanalyzer.h
index a80f774..3414bc7 100644
--- a/src/link/linkstatusanalyzer.h
+++ b/src/link/linkstatusanalyzer.h
@@ -25,7 +25,7 @@ public:
             const int link_up_interval_in_min,
             const std::string &status_notifier_cmd
     );
-    virtual ~LinkStatusAnalyzer();
+    ~LinkStatusAnalyzer();
 
     void notify_host_up( const std::string &host_address );
     void notify_host_down( const std::string &host_address );