From: Christian Herdtweck <christian.herdtweck@intra2net.com>
Date: Wed, 24 Oct 2018 13:18:52 +0000 (+0200)
Subject: Make debug print in test optional
X-Git-Tag: v1.3~4
X-Git-Url: http://developer.intra2net.com/git/?a=commitdiff_plain;h=7c00b0afb48d8f950ca5a9ca04911f96606ac49e;p=pyi2ncommon

Make debug print in test optional
---

diff --git a/test/test_log_read.py b/test/test_log_read.py
index 2074f59..daf8ea6 100644
--- a/test/test_log_read.py
+++ b/test/test_log_read.py
@@ -41,6 +41,8 @@ elif version_info.minor < 4:
 else:
     perf_counter = time.perf_counter
 
+DEBUG = False
+
 
 class LogFileWriter(Thread):
     """ thread that creates and writes to given file """
@@ -103,7 +105,6 @@ class LogFileWriter(Thread):
         if self.do_encode:
             text = text.encode(self.do_encode)
         write_func(text)
-        #print('wrote {0}'.format(counter))
         time.sleep(self.pause_time)
 
 
@@ -112,17 +113,21 @@ class LogReadTester(unittest.TestCase):
 
     def setUp(self):
         """ called before each test """
-        print('setup test')
+        if DEBUG:
+            print('setup test')
         temp_handle, temp_name = mkstemp()
         os.close(temp_handle)
         self.temp_file = temp_name
-        print('created temp file ' + self.temp_file)
+        if DEBUG:
+            print('created temp file ' + self.temp_file)
 
     def tearDown(self):
         """ called after each test """
-        print('tear down test')
+        if DEBUG:
+            print('tear down test')
         if os.path.isfile(self.temp_file):
-            print('delete temp file' + self.temp_file)
+            if DEBUG:
+                print('delete temp file' + self.temp_file)
             os.unlink(self.temp_file)
 
     def helper_test_len(self, reader, n_expected):
@@ -184,9 +189,10 @@ class LogReadTester(unittest.TestCase):
             LogFileWriter(self.temp_file, text_pattern, n_writes=n_texts,
                           pause_time=pause_time, do_encode=encoding,
                           use_logging=use_logging).start()
-            print('testing with log file {0}'.format(self.temp_file))
-            print('encoding is {0}, use logging = {1}'.format(encoding,
-                                                              use_logging))
+            if DEBUG:
+                print('testing with log file {0}'.format(self.temp_file))
+                print('encoding is {0}, use logging = {1}'.format(encoding,
+                                                                  use_logging))
             time_diffs = []
 
             with open(self.temp_file, 'rt') as file_handle:
@@ -195,17 +201,20 @@ class LogReadTester(unittest.TestCase):
                 for counter, (desc, text) in enumerate(reader):
                     receive_time = perf_counter()
                     text = text.strip()
-                    print('{1}: received text "{0}" at {2}'
-                          .format(text, counter, receive_time))
+                    if DEBUG:
+                        print('{1}: received text "{0}" at {2}'
+                              .format(text, counter, receive_time))
                     index = text.index(':')
                     count_text = int(text[:index].strip())
                     self.assertEqual(count_text, counter)
                     write_time = float(text[index+1:].strip())
                     time_diffs.append((receive_time - write_time)*1000.)
                     if counter == n_texts-1:
-                        print('stop since have {0} reads'.format(counter))
+                        if DEBUG:
+                            print('stop since have {0} reads'.format(counter))
                         break
-            print('time diffs in ms: {0}'.format(time_diffs))
+            if DEBUG:
+                print('time diffs in ms: {0}'.format(time_diffs))
             self.assertTrue(max(time_diffs) < 100.,
                             'read took more than 100ms (max was {0:.3f}ms)!'
                             .format(max(time_diffs)))
@@ -238,8 +247,9 @@ class LogReadTester(unittest.TestCase):
                 if 'end' in line_read:
                     break
                 else:
-                    print('expect "{0}", read "{1}"'.format(line_expected,
-                                                            line_read))
+                    if DEBUG:
+                        print('expect "{0}", read "{1}"'.format(line_expected,
+                                                                line_read))
                     self.assertEqual(line_expected, line_read)